error msg if version is missing #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Not so sure about the test 🤷♂️ |
keewis
reviewed
Sep 10, 2025
Comment on lines
+363
to
+366
| _main(today, policy_file, environment_paths) | ||
|
|
||
|
|
||
| def _main(today, policy_file, environment_paths): |
There was a problem hiding this comment.
we might need to clean this up a bit: currently _main would call sys.exit, which is not great for testing. It also should take the contents of the files instead of file handles / paths, which avoids the need to do I/O in the tests.
Additionally, _main is not really a descriptive name. How about something like validate_environment instead?
Comment on lines
+383
to
+384
| assert_spec_has_version(environments) | ||
|
|
There was a problem hiding this comment.
I wonder if this should be done at the same time as applying exclude? I don't have the time to come up with something better right now, but assuming this isn't too urgent I will spend some time on this later this week.
|
also, does this close #28? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a clearer error message a package is missing a version in the environment file (and is not in
exclude. Currently raisesAttributeError: 'NoneType' object has no attribute '_version'